On Tue, 1 Jun 2010 01:50:45 -0700 "Nicholas A. Bellinger" <nab@xxxxxxxxxxxxxxx> wrote: > This patch adds two new queueing and completion function pointers to > struct scsi_lu called ->cmd_perform() and ->cmd_done() for handling > existing internal STGT port emulation and the struct scsi_cmd Using new function pointers look fine. However, have you tried the existing non passthrough code? This patch seems to break it. I've not looked at the details though. I don't think you need to touch to sbc.c. we should not need to know the type of underlying devices with passthough. Can you add a new device type such as struct device_type_template sg_template? __cmd_done_passthrough() doesn't need to call post_cmd_done(), I think because post_cmd_done() checks the pending commands. With passthrough, there is no pending commands. Thanks, -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
