Re: [PATCH] usr/Makefile: Turn off build warning in new gcc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/16/2010 01:06 AM, FUJITA Tomonori wrote:
> On Mon, 15 Mar 2010 16:27:02 +0200
> Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> 
>> diff --git a/usr/Makefile b/usr/Makefile
>> index 2dcae2a..262300d 100644
>> --- a/usr/Makefile
>> +++ b/usr/Makefile
>> @@ -53,7 +53,7 @@ INCLUDES += -I.
>>  
>>  CFLAGS += -D_GNU_SOURCE
>>  CFLAGS += $(INCLUDES)
>> -CFLAGS += -g -O2 -Wall -Wstrict-prototypes -fPIC
>> +CFLAGS += -g -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -fPIC
>>  CFLAGS += -DTGT_VERSION=\"$(VERSION)$(EXTRAVERSION)\"
> 
> Applied, thanks.
> 
> We could "fix" the code but I guess that linux kernel also has this
> option. Silencing the warnings is acceptable in this way, I guess.

On x86 this does nothing. There are some platforms (A minority at that),
that gcc will produce slower, fatter code. I don't think, any of these
are really interesting to tgt users. (Let's leave it at innocent until
proven guilty)

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux