On Wed, 24 Feb 2010 14:29:18 +1100 ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote: > The part of the patch where we control the management channel seems to > have been lost/forgotten. > > Please find a patch attached that contains an updated version Or's > patch for specifying the management channel > to allow us to run multiple instances of tgtd concurrently. > > This can be useful in testing since on very powerful machines, the > single thread for the eventloop reaches 100% of one core, this caps > performance. adding specifying management port support is fine by me, as I said before, I don't fancy running multiple tgtd though. I have two comments: 1. We already have long options like "initiator-address" so I like clear long options. Something like 'management-port' or 'control-port' instead of 'mgmt-port'? 2. Is it better to have the same short option for tgtd and tgtadm? Thanks, -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html