Re: [PATCH 1/1] Add a manpage for TGTD in XSLT format and makefile changes to build it.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 17 Feb 2010 17:18:57 +1100
ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:

> >>  doc/Makefile              |   17 ++++++-
> >>  doc/htmlpages/tgtd.8.html |   40 +++++++++++++++
> >>  doc/manpages/tgtd.8       |   81 +++++++++++++++++++++++++++++
> >
> > Do we need to add tgtd.8.html and tgtd.8? I thought that xsltproc
> > generates them from tgtd.8.xml?
> 
> They are needed for the case when the user does not have xsltproc
> installed and configured.
> 
> So for those users, they can still "make" and "make install" and these
> files are installed. These users just get the
> pregenerated ones that came from the git tree instead of
> updating/creating these files.
> 
> Otherwise these users wouldn't get the docs, and forcing them to
> install xsltproc would be "rude".
> This way you only need to install xsltproc if you want to update and
> rebuild the docs.

Thanks, I see.


> >> +manpages/tgtd.8: tgtd.8.xml
> >> +     -test -z "$(XSLTPROC)" || $(XSLTPROC) -o $@ http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl $<
> >> +
> >> +htmlpages/tgtd.8.html: tgtd.8.xml
> >> +     -test -z "$(XSLTPROC)" || $(XSLTPROC) -o $@ http://docbook.sourceforge.net/release/xsl/current/html/docbook.xsl $<
> >
> > It means that it tries to connect to docbook.sf.net? If so, can we use
> > the local files instead?
> 
> Good point.
> I have updated the makefile to use the local files. Attached is a new patch.

I guess that other distributions might use different paths?

Is there any clever way to find appropriate style files? If not, it
would be ok to have our local copies, I guess.
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux