Sorry about the previous message subject line, it was just a warning.
Must have been the
Christmas food that's bugging me ;-)
Albert
--
Compiling stgt gives a warning in sbc.c:
sbc.c: In function ‘sbc_read_capacity’:
sbc.c:131: warning: suggest parentheses around operand of ‘!’ or change
‘&’ to ‘&&’ or ‘!’ to ‘~’
Several options are possible, I made the attached patch.
This doesn't change any of the operators but got rid of the warning.
Albert
--- usr/sbc.c 2009-12-27 10:12:27.117551785 +0100
+++ usr/sbc.c.me 2009-12-27 10:12:20.707559801 +0100
@@ -128,7 +128,7 @@
unsigned char key = ILLEGAL_REQUEST;
uint16_t asc = ASC_LUN_NOT_SUPPORTED;
- if (!(scb[8] & 0x1) & (scb[2] | scb[3] | scb[4] | scb[5])) {
+ if (!(scb[8] & 0x1) && (scb[2] | scb[3] | scb[4] | scb[5])) {
asc = ASC_INVALID_FIELD_IN_CDB;
goto sense;
}
