Chris Boot wrote:
Tomasz Chmielewski wrote:
Chris Boot wrote:
All,
I wanted to play with different backing store types on iSCSI targets,
but keep using tgt-admin and /etc/tgt/targets.conf. I noticed
tgt-admin didn't have a way of setting the bs type, so here's a patch
to let it do it.
Looks OK - but please also add example usage to doc/targets.conf.example.
Thanks for the feedback. Indeed that would make sense! I've added a
couple of lines to the file - one as a proper example on one of the
targets (but commented out) and another in the list of parameters with a
few words to describe the new parameter. Hope it's up to scratch!
Again, apologies for the attachment.
Signed-off-by: Chris Boot <bootc@xxxxxxxxx>
Acked-by: Tomasz Chmielewski <mangoo@xxxxxxxx>
I think you should use one patch per (logically) patched file here.
Otherwise, the example config file looks OK to me.
--
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html