On 2009-10-01 10:51, FUJITA Tomonori wrote: > On Thu, 01 Oct 2009 10:29:18 +0200 > Florian Haas <florian.haas@xxxxxxxxxx> wrote: > >>> Just split Makefile. It's fine by me. Then you can easily maintain >>> your changes in your own tree. >> That's not even necessary. All that would need to happen is adding the >> Debian specific init script to the debian branch, as tgt.init in >> debian/. dh_installinit then does the rest. > > If you maintain the debian branch in your own git tree, it's fine by > me. OK. I don't plan to pursue becoming the package maintainer for Debian (nor RPM based distros, for that matter), but if my trees are helpful to the maintainers, then great. >> Would you be OK with merging the Makefile changes as proposed in >> yesterday's patch set of mine, if the init script and sysconfig file >> were thrown out and moved to the rpm branch? Likewise that would imply >> that the defaults file and the Debian init script only go into the >> debian branch. If so, I can re-roll the patch. > > Splitting Makefile is fine by me (if all the stuff related with rpm > specific files are removed). OK. > A downloaded tarball can't set VERSION, right? If so, I don't like > that change. I like using git-describe though. The downloaded tarball, if built with "make tarball", would include version-stamp, which the top-level Makefile includes and which contains "VERSION ?= <version string>". So it would know its correct version, and that version can _still_ be overridden by invoking "make VERSION=<whatever>". I'll reroll the patch, and rebase the branches, before the end of the week. Cheers, Florian
Attachment:
signature.asc
Description: OpenPGP digital signature
