On Mon, 07 Sep 2009 17:30:06 +0300
Alexander Nezhinsky <alexandern@xxxxxxxxxxxx> wrote:
> Prints out the type of a backing store per device in --mode target --op show
>
> Signed-off-by: Alexander Nezhinsky <alexandern@xxxxxxxxxxxx>
> ---
> usr/target.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
Looks fine but the patch format is corrupted (tabs were converted to
spaces). Can you resend the proper one?
> diff --git a/usr/target.c b/usr/target.c
> index 9d979bf..3922bbc 100644
> --- a/usr/target.c
> +++ b/usr/target.c
> @@ -1601,7 +1601,8 @@ int tgt_target_show_all(char *buf, int rest)
> _TAB3 "Size: %s\n"
> _TAB3 "Online: %s\n"
> _TAB3 "Removable media: %s\n"
> - _TAB3 "Backing store: %s\n",
> + _TAB3 "Backing store type: %s\n"
> + _TAB3 "Backing store device: %s\n",
I think that 'Backing store path:' is accurate.
> lu->lun,
> print_type(lu->attrs.device_type),
> lu->attrs.scsi_id,
> @@ -1609,6 +1610,7 @@ int tgt_target_show_all(char *buf, int rest)
> print_disksize(lu->size),
> lu->attrs.online ? "Yes" : "No",
> lu->attrs.removable ? "Yes" : "No",
> + lu->bst->bs_name ? : "Unknown",
> lu->path ? : "No backing store");
>
> if (!strcmp(tgt_drivers[target->lid]->name, "iscsi")) {
> --
> 1.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe stgt" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
