On Wed, 17 Jun 2009 18:02:38 -0700 Daniel Smith <dfsmith@xxxxxxxxxxxxxxx> wrote: > > As far as I can tell, an isid of 0 is valid during iSCSI login (the OUI > belongs to Xerox). What was the reason for this code in iscsi/iscsid.c? > > static void login_start(struct iscsi_connection *conn) > ... > if (!sid64(conn->isid, conn->tsih)) { > rsp->status_class = ISCSI_STATUS_CLS_INITIATOR_ERR; > rsp->status_detail = ISCSI_LOGIN_STATUS_MISSING_FIELDS; > conn->state = STATE_EXIT; > return; > } Yeah, seems this code is wrong. I guess that we inherit this from IET. IET might inherit it from Ardis. I can't recall. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html