On Wed, 11 Mar 2009 10:12:38 +0100 Hannes Reinecke <hare@xxxxxxx> wrote: > Hi all, > > Albert Pauw wrote: > > Yes, that's it! > > > > Works fine again. > > > > Thanks! > >> > >> This works (against the latest git, again)? > >> > >> > >> diff --git a/usr/tgtadm.h b/usr/tgtadm.h > >> index 5d63485..60b984d 100644 > >> --- a/usr/tgtadm.h > >> +++ b/usr/tgtadm.h > >> @@ -1,7 +1,7 @@ > >> #ifndef TGTADM_H > >> #define TGTADM_H > >> > >> -#define TGT_IPC_NAMESPACE "TGT_IPC_ABSTRACT_NAMESPACE" > >> +#define TGT_IPC_NAMESPACE "/tmp/.TGT_IPC_ABSTRACT_NAMESPACE" > >> #define TGT_LLD_NAME_LEN 64 > >> > >> #include "tgtadm_error.h" > >> > But doesn't this counteract the idea of an abstract namespace? > IE you have to have /tmp mounted and accessible here, as the > socket is created in the /tmp directory, not the abstract > namespace as previously. Yeah, our problem is that the abstract namespace is Linux-specific. It's not portable. > Not that is matters much here, as the daemon most certainly > will only run when the root fs is set up properly, but using > /tmp as a socket storage is a bad move. And it's certainly > _not_ an abstract namespace anymore, so we can as well > rename it to something sensible and move it to /var/run > or somesuch. Using /tmp for unix domain sockets is not common? On my box, X server, gdm, etc use /tmp. -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
