"../include" does not exist in git-tree. It was perhaps added
so a manual copy of missing Kernel headers for out-of-distro modules
could be manually copied to ../include/ directory, without need to
change Makefile. This should not be done, because it is an half baked
solution. If iser/ib, fc, fcoe, or kernel transport might want
out-of-tree includes they can do it as:
ifneq ($(FOO),)
CFLAGS += -DFOO_STUFF
INCLUDES += FOO_INCLUDES
endif
Then user can do: make FOO_INCLUDES=../path_to_foo -C usr/tgt.
The headers are then picked up without a copy, and dependencies also
work properly. Note that currently none of this is needed if the proper
dependencies are met according to documentation for example:
$ yum install librdmacm-devel libibverbs-devel
-I$(KERNELSRC)/include was perhaps used to fetch
../include/scsi/scsi_tgt_if.h. (Without changing Makefile). This is
wrong either include/scsi/scsi_tgt_if.h is exported together with the
Kernel headers, or it is included in the tgt git-tree at ../include,
and added to Makefile at that time.
Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx>
CC: Pete Wyckoff <pw@xxxxxxxx>
---
usr/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/usr/Makefile b/usr/Makefile
index f76cac2..3fc848e 100644
--- a/usr/Makefile
+++ b/usr/Makefile
@@ -50,7 +50,7 @@ TGTD_OBJS += $(addprefix fcoe/,\
TGTD_OBJS += bs_rdwr.o
endif
-INCLUDES += -I. -I../include -I$(KERNELSRC)/include
+INCLUDES += -I.
CFLAGS += -D_GNU_SOURCE
CFLAGS += $(INCLUDES)
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
