On Thu, 16 Oct 2008 12:21:21 +0200 Tomasz Chmielewski <mangoo@xxxxxxxx> wrote: > FUJITA Tomonori schrieb: > > On Thu, 16 Oct 2008 10:35:29 +0200 > > Tomasz Chmielewski <mangoo@xxxxxxxx> wrote: > > > >> In recent git, setting write cache to off fails: > >> > >> # tgtadm --lld iscsi --op update --mode logicalunit --tid 2 --lun=1 --params mode_page=8:0:18:0x10:0:0xff:0xff:0:0:0xff:0xff:0xff:0xff:0x80:0x14:0:0:0:0:0:0 > >> tgtadm: option 5 not supported in logicalunit mode > >> > >> > >> I checked the git from 2008-10-16 and 2008-10-15. > >> > >> It works fine (i.e., I'm able to disable write cache) in git fetched on 2008-10-13. > > > > I think that this fixes the update operations in the logicalunit mode > > though there might be other regressions about the tgtadm. > > Indeed, that patch helps. Thanks, merged. Doron, are you writing up all the options of tgtadm (as you suggested)? It also helps us to verify if tgtadm checks all the options properly (in other words, we can avoid bugs like this). -- To unsubscribe from this list: send the line "unsubscribe stgt" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
