Re: [PATCH 1/2] tgt-admin: allow to change tuning parameters (MaxRecvDataSegmentLength...)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



FUJITA Tomonori schrieb:
On Tue, 14 Oct 2008 16:36:46 +0200
Tomasz Chmielewski <mangoo@xxxxxxxx> wrote:

FUJITA Tomonori schrieb:
On Mon, 13 Oct 2008 12:37:07 +0200
Tomasz Chmielewski <mangoo@xxxxxxxx> wrote:

Tomasz Chmielewski schrieb:
Allow changing parameters like MaxRecvDataSegmentLength,
MaxXmitDataSegmentLength, HeaderDigest etc.
This didn't look like a proper patch here:

+ ^MaxConnections/x) { + # if we have one command, force it to be an array anyway
Let's try once again...


Signed-off-by: Tomasz Chmielewski <mangoo@xxxxxxxx>
Applied, thanks.

I think that it would be better to write clearly what parameters are
iSCSI specific in targets.conf.example
You mean, everything but:

+    #IFMarker No
+    #OFMarker No
+    #OFMarkInt Reject
+    #IFMarkInt Reject


Everything you added. targets.conf.example also includes other iSCSI
parameters like initiator-address, incomminguser, outgoinguser.

Ah, I see.
It might be also a good idea to document them in a separate file. IET has a pretty good description of those in ietd.conf manual.


What's the meaning of the above, by the way?

The meanings of the above parameters?

Yes - what are IFMarker, OFMarker, OFMarkInt, IFMarkInt for? I didn't find it documented, and it doesn't seem to be commented in the code.


--
Tomasz Chmielewski
http://wpkg.org
--
To unsubscribe from this list: send the line "unsubscribe stgt" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SCSI]     [Linux RAID]     [Linux Clusters]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]

  Powered by Linux