On Thu, Feb 20, 2025 at 04:12:38PM +0100, Hans Verkuil wrote: > On 2/20/25 15:06, Andy Shevchenko wrote: > > On Thu, Feb 20, 2025 at 02:55:42PM +0100, Hans Verkuil wrote: > >> On 12/3/24 09:31, Mauro Carvalho Chehab wrote: ... > >> ORing enums is really not a good idea: you would normally never do that, and > > > > I think you missed a keyword "different", so "ORing different enums ..." > > which I totally agree on, but the same enum values are fine. > > While the compiler might be happy with that, I think ORing enums regardless > is weird. It's not what enums are for. I disagree. It's totally normal to have "mixed" enums where we have ranges of sequential values mixed with bit flags. Cross-enum bit operations (and what this patch is about) should be prohibited, indeed. > >> the compiler warning is IMHO appropriate. -- With Best Regards, Andy Shevchenko
