On Wed, Jan 08, 2025 at 06:41:58PM +0100, Dave Penkler wrote: > When no matching product id was found in the attach function the driver > returned without unlocking the agilent_82357a_hotplug_lock mutex. > > Add the unlock call. > > This was detected by smatch: > smatch warnings: > drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/r/202412210143.WJhYzXfD-lkp@xxxxxxxxx/ > Fixes: 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver") > Signed-off-by: Dave Penkler <dpenkler@xxxxxxxxx> > --- > v1 -> v2 Add subsystem prefix in subject You sent 2 patches with identical subject lines, yet they do different things. That's not good, can you fix them both up and resend? thanks, greg k-h
