Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-01-03 at 07:44 +0100, Philipp Hortmann wrote:
> 
> One of my big fears is the hand over to the next generation maintainers 
> and developers. The less code and the less exceptions due to old 
> interfaces the easier it will be. We loose maintainers and developers 
> for many reasons, like: retirement, burnout, embargos or simply because 
> they are not paid and need to earn money. After giving some support on 
> the staging subsystem I cannot see at all that we can attract so many 
> talented people as required for a save future beyond 7 years...

I wouldn't say that's necessarily a wrong sentiment, but I feel future
maintainers can also make that decision, and if it's "years" in the
future the relevance will only go down anyway.

We just started putting some pressure into the system for removal of
wext and nl80211 support (with WiFi7 devices no longer supporting wext)
so chances are at least here the situation will change, and anyway wext
stuff will become less relevant, perhaps to the point that other tools
will drop support for it anyway. Not wpa_supplicant though, I suppose :)

> People who evolved with the kernel development do not have a good sense 
> how difficult it can be to join nowadays.
> 
> A friend just bought two servers. One with a paid OS and one planned 
> with Linux as OS. The difference was over 12000 € due to licenses. What 
> would be the price when we do not have a choice? Do not feel save 
> because of today. We need to fight for tomorrow.

Not sure I see how that's related. This stuff really isn't in the way
now. If it were, I might have killed it already like the staging
driver(s).

> Where do you want to invest your time? Into the new technologies to keep 
> up at the front edge or to keep old stuff running that is not productive 
> anymore. But there might be someone who can pull the hardware once every 
> two month out of the shelf and ask why this is not working. Should this 
> really stop us from progress?

Again, I don't see the correlation, much less causation. Keeping the
wext stuff working for now is a promise for stable APIs for existing
things anyway. IMHO progress isn't achieved by removing old things
gratuitously but by offering better ways and moving things over. Which
_is_ happening, just that this particular driver is a hold-out because
progress happened in a direction that didn't add support for it.

> Partial, for me more important was the try to remove all wext drivers in 
> October 2023 by Arnd Bergmann.
> [PATCH] [RFC] wireless: move obsolete drivers to staging
> https://lore.kernel.org/linux-staging/20231010155444.858483-1-arnd@xxxxxxxxxx/

I don't think this was really all that much about "remove wext" rather
than "remove obsolete stuff".

> I was not able to use the WLAN on T2 Linux. I just tested the Ethernet 
> connection as I know that the developer of T2 is using it. The reason 
> why I bought the PS3 is to see if Linux on it is really a use case. But 
> all I found is that it is only a test vehicle to say T2 is working on 
> Power PC architecture.

Power is vastly more than PS3, the SPU/cell architecture was more the
interesting part of PS3 rather than anything else.

> At the time the PS3 WLAN driver was added to the mainline kernel it was 
> really cool stuff. But nowadays it is just a high Power consuming device 
> with a noisy fan and not enough RAM to do anything (256MB). The 
> powerfull GPU is not supported by the kernel.
> 
> Do I need to find out why the WLAN is not working under T2 on PS3 to 
> convince you? The WLAN is working under redribbon Linux with Kernel 3.5 
> on the PS3.

That's a whole different argument, so you're saying it wasn't working
_anyway_? Your whole original patch/argument seemed to be centered
around a whole lot of other things, but if it's not working anyway and 

> T2 is working but to make this happen the T2 Author has an own repo for 
> patches to apply. In the following video he publishes his view on how 
> well the ps3disk is maintained and tested by the linux kernel community. 
> My impression of this is that ps3disk is not tested on hardware at all.
> You can find this in a youtube video: “I can't believe VIP Linux kernel 
> developer BROKE PS3 support” but watch out that you are in a good mood 
> otherwise it is pulling you down like me...

That's on him, things get broken all the time. I guess rants sell better
*shrug*.

> The following points are also in the list of reasons:
> - This driver has a maximum 54MBit/s as it supports only 802.11 b/g.
> - Using this hardware is security wise not state of the art as WPA3 is
>    not supported.

Neither of those is really all that relevant, there are plenty other
11g-only drivers and/or without WPA3, and WPA3 anyway isn't all that
critical. Crypto in WPA2 isn't broken (in fact it's mostly the same as
WPA3), it's just (slightly) less susceptible to DOS attacks due to MFP.


Anyway ... if it's broken it _would_ be nice to know why, just to know
how long ago that was I guess, but we can also remove it with that
argument. I just think that's a completely different argument ("it's
broken and nobody cared in a few years") than what your patch now
implies ("it's working but too old".)

johannes





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux