On Tue, Dec 10, 2024 at 05:48:19PM -0300, Rodrigo Gobbi wrote:
> After removing code isolated by DBG_RX_SIGNAL_DISPLAY_RAW_DATA cflag,
> HAL_DEF_DBG_RX_INFO_DUMP enum lost it's use.
>
> Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 2 --
> drivers/staging/rtl8723bs/include/hal_intf.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 1803c0cd3a7e..b41ec89932af 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -682,8 +682,6 @@ u8 SetHalDefVar(
> u8 bResult = _SUCCESS;
>
> switch (variable) {
> - case HAL_DEF_DBG_RX_INFO_DUMP:
> - break;
> case HW_DEF_ODM_DBG_FLAG:
> ODM_CmnInfoUpdate(odm, ODM_CMNINFO_DBG_COMP, *((u64 *)value));
> break;
> diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
> index 282e141616b0..85de862823c2 100644
> --- a/drivers/staging/rtl8723bs/include/hal_intf.h
> +++ b/drivers/staging/rtl8723bs/include/hal_intf.h
> @@ -144,7 +144,6 @@ enum hal_def_variable {
> HAL_DEF_PCI_AMD_L1_SUPPORT,
> HAL_DEF_PCI_ASPM_OSC, /* Support for ASPM OSC, added by Roger, 2013.03.27. */
> HAL_DEF_MACID_SLEEP, /* Support for MACID sleep */
> - HAL_DEF_DBG_RX_INFO_DUMP,
You have to combine patch 2 and 3 together otherwise it breaks the build.
The fact that any mistakes break the build is what makes this sort of patch
easy to review.
regards,
dan carpenter
