Hi
Am 10.12.24 um 15:34 schrieb Helge Deller:
On 12/10/24 15:29, Helge Deller wrote:
On 12/10/24 15:09, Thomas Zimmermann wrote:
diff --git a/drivers/staging/fbtft/Kconfig
b/drivers/staging/fbtft/Kconfig
index 77ab44362f16..577e91ff7bf6 100644
--- a/drivers/staging/fbtft/Kconfig
+++ b/drivers/staging/fbtft/Kconfig
@@ -3,6 +3,7 @@ menuconfig FB_TFT
tristate "Support for small TFT LCD display modules"
depends on FB && SPI
depends on FB_DEVICE
+ depends on BACKLIGHT_DEVICE_CLASS
Typo. Should be BACKLIGHT_CLASS_DEVICE...
Ah, thanks. I'll better check the rest of the series for similar mistakes.
Beside the typo:
In this case, doesn't it make sense to "select BACKLIGHT_DEVICE_CLASS"
instead?
That causes the dependency error mentioned in the commit message. This
time it's just for fbtft instead of shmobilefb.
If people want the fbtft, backlight support should be enabled too.
As a user-visible option, it should not be auto-selected unnecessarily.
The DRM panel drivers already depend on the backlight instead of
selecting it. It's the correct approach. As I mentioned in the cover
letter, the few remaining driver that select it should probably be updated.
Best regards
Thomas
Helge
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
