Re: [PATCH v2] staging: rtl8723bs: Cleanups for rtw_inc_and_chk_continual_io_error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 05, 2024 at 10:16:10AM +0800, Chenguang Zhao wrote:
> There's a warning when using checkpatch.pl check rtw_io.c:
> 
>     WARNING: Missing a blank line after declarations
>     146: FILE: drivers/staging/rtl8723bs/core/rtw_io.c:146:
>     int value = atomic_inc_return(&dvobj->continual_io_error);
>     if (value > MAX_CONTINUAL_IO_ERR)
> 
> The patch fixes it.
> 
> In addition, also rename 'value' variable to 'error_count' and drop
> 'ret' variable.
> 
> Signed-off-by: Chenguang Zhao <zhaochenguang@xxxxxxxxxx>
> ---
> v2:
>  - rename 'value' variable to 'error_count' and drop 'ret' variable
>  as Dan suggested.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux