This commit fixes a dereference before null check issue discovered by
Coverity (CID 1601566).
The check ad line 1450 suggests that a_priv can be NULL, however it has
been derefenced before, in the interface_to_usbdev() call.
Signed-off-by: Paolo Perego <pperego@xxxxxxx>
---
drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
index bf05fb4a736b..604e13c32dfb 100644
--- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -1446,8 +1446,8 @@ static void agilent_82357a_detach(gpib_board_t *board)
mutex_lock(&agilent_82357a_hotplug_lock);
a_priv = board->private_data;
- usb_dev = interface_to_usbdev(a_priv->bus_interface);
if (a_priv) {
+ usb_dev = interface_to_usbdev(a_priv->bus_interface);
if (a_priv->bus_interface) {
agilent_82357a_go_idle(board);
usb_set_intfdata(a_priv->bus_interface, NULL);
--
2.47.0
