Hello Dave Penkler,
This is a semi-automatic email about new static checker warnings.
Commit fbae7090f30c ("staging: gpib: Update messaging and usb_device
refs in agilent_usb") from Nov 4, 2024, leads to the following Smatch
complaint:
drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1450 agilent_82357a_detach()
warn: variable dereferenced before check 'a_priv' (see line 1449)
drivers/staging/gpib/agilent_82357a/agilent_82357a.c
1448 a_priv = board->private_data;
1449 usb_dev = interface_to_usbdev(a_priv->bus_interface);
^^^^^^^^
The patch added a dereference
1450 if (a_priv) {
^^^^^^
right before a NULL check. I don't think it can actually be NULL. It gets
allocated in the attach() function. Could you remove this NULL check?
1451 if (a_priv->bus_interface) {
1452 agilent_82357a_go_idle(board);
regards,
dan carpenter
