On Thu, Oct 17, 2024 at 09:54:47PM +0200, Kees Bakker wrote:
> The code was basically like this (assuming size_t can be u64)
> var_u64 |= var_u8 << 24
> var_u8 is first promoted to i32 and then the shift is done. Next, it is
> promoted to u64 by first signextending to 64 bits. This is very unlikely
> what was intended. So now it is first forced to u32.
> var_u64 |= (u32)var_u8 << 24
>
> This was detected by Coverity, CID 1600792.
>
> Fixes: 4c41fe886a56 ("staging: gpib: Add Agilent/Keysight 82357x USB GPIB driver")
> Signed-off-by: Kees Bakker <kees@xxxxxxxxxxxx>
> ---
> V1 -> V2: Changed commit message, added Fixes: tag and a reference to the Coverity CID
> V2 -> V3: add version in the subject (sorry Greg)
Doesn't apply cleanly anymore :(
Also, always cc: all of the relevent people that get_maintainer.pl says
to cc:. Can you rebase this against my staging-testing branch and
resend?
thanks,
greg k-h
