Re: staging: rtl8723bs: change remaining printk to proper api

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Why are you pasing -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA?
> ... But if there is some external document which says to enable it, and it's
> useful stuff then maybe we should keep it?

I've enabled this in an arbitrary way just to check the rtw_dump_raw_rssi_info()
because I was doing the debug replacement within the isolated code. Looking again,
I didn't find any documentation about this and the history of some files, the #ifdef 
macro is very old...from 7years ago. We can remove this for sure.

> If it's not used, just delete it?
Ok, I'll do it in a next patch too.

> ...as you've looked at the
> initialization path and it's okay as you said.
Ok, I'll send a v4.

Tks again and regards!




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux