First, tks for the answer, Dan.
> little broken with -DDBG_RX_SIGNAL_DISPLAY_RAW_DATA, maybe we can
> fix that in a next patch.
> How is it broken?
make -j<> ./drivers/staging/rtl8723bs/r8723bs.ko EXTRA_CFLAGS="-DDBG_RX_SIGNAL_DISPLAY_RAW_DATA"
drivers/staging/rtl8723bs/hal/hal_com.c: In function ‘rtw_store_phy_info’:
drivers/staging/rtl8723bs/hal/hal_com.c:927:43: error: ‘PODM_PHY_INFO_T’ undeclared (first use in this function)
927 | struct odm_phy_info *pPhyInfo = (PODM_PHY_INFO_T)(&pattrib->phy_info);
| ^~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/hal/hal_com.c:927:43: note: each undeclared identifier is reported only once for each function it appears in
drivers/staging/rtl8723bs/hal/hal_com.c:940:73: error: ‘struct odm_phy_info’ has no member named ‘RxPwr’; did you mean ‘rx_pwr’?
940 | psample_pkt_rssi->ofdm_pwr[rf_path] = pPhyInfo->RxPwr[rf_path];
| ^~~~~
| rx_pwr
drivers/staging/rtl8723bs/hal/hal_com.c:941:71: error: ‘struct odm_phy_info’ has no member named ‘RxSNR’
941 | psample_pkt_rssi->ofdm_snr[rf_path] = pPhyInfo->RxSNR[rf_path];
Actually it's not exaclty in the same line of pr_debug/netdev_dbg replacement. Do you think
we can do the replacement at:
> + pr_debug(", rx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n",...
regardless of this build errors? I mean, fixing it here in this patch
would not be related to the purpose of this simple patch.
> Just delete this line.
Ok.
> - printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
> + pr_crit("%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
> ^^^^^^^?
Originally, I didn't replace this because at dvobj of sdio_alloc_irq(struct dvobj_priv *dvobj)
there are two adapter fields:
struct dvobj_priv {
struct adapter *if1; /* PRIMARY_ADAPTER */
...
struct adapter *padapters;
...
}
Checking the "counter part" function of sdio_alloc_irq(), the sdio_free_irq() (which is not used),
the if1 (primary) is used for debug purpose:
netdev_err(dvobj->if1->pnetdev...
And checking the initialization path, if1 should be ok at this point.
But since I can't test this, do you suggest to replace anyway?
Tks and regards.
