On Wed, Oct 16, 2024 at 8:20 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > Keep up the good work, Everest. Here are some other bugs you could fix if you > want. Thank you for all your feedback and help. I am learning a lot :) I will look into these and try my best to fix them and send patches. > drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns '&agilent_82357a_hotplug_lock'. > drivers/staging/gpib/common/gpib_os.c:889 board_type_ioctl() warn: maybe return -EFAULT instead of the bytes remaining? > drivers/staging/gpib/common/iblib.c:242 ibonline() warn: assigning IS_ERR() > drivers/staging/gpib/common/iblib.c:505 ibsad() warn: AAA no lower bound on 'addr' rl='s32min-30' > drivers/staging/gpib/eastwood/fluke_gpib.c:592 fluke_dma_read() error: NULL dereference inside function 'dma_unmap_single_attrs((0), bus_address, length, 2, 0)()'. '0' '(0)' 17 9 > drivers/staging/gpib/eastwood/fluke_gpib.c:592 fluke_dma_read() error: NULL dereference inside function (pos=17) > drivers/staging/gpib/eastwood/fluke_gpib.c:949 fluke_init() warn: was hexadecimal intended '10' > (perhaps intentional? Just leave it if so.) > drivers/staging/gpib/ni_usb/ni_usb_gpib.c:837 ni_usb_write() warn: inconsistent returns '&ni_priv->addressed_transfer_lock'. > drivers/staging/gpib/ni_usb/ni_usb_gpib.c:1103 ni_usb_request_system_control() error: uninitialized symbol 'ibsta'. > (this last bug is tricky to spot.) > > regards, > dan carpenter > > Thanks, Everest K.C.
