On Thu, Oct 17, 2024 at 02:20:22AM -0600, Everest K.C. wrote:
> fluke_get_dma_residue() returns unsigned int with -1 as error code.
> This error cannot be caught.
> Fix this by changing the return type of the function to int and
> returning the error code, that was captured.
>
> Fixes: 55936779f496 ("staging: gpib: Add Fluke cda based cards GPIB driver")
> Signed-off-by: Everest K.C. <everestkc@xxxxxxxxxxxxxxxx>
> ---
So like quite often we would merge a patch like this, because there's nothing
wrong with it and why not? It's a step in the right direction. But actually
in this case could you fix the caller as well?
Do it all in the same patch. It's the one *whole* thing per patch rule.
regards,
dan carpenter
