Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>
Subject: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable
From: Roger Quadros <rogerq@xxxxxxxxxx>
Date: Wed, 16 Oct 2024 21:57:58 +0300
Cc: Andrew Lunn <andrew+netdev@xxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Dave Penkler <dpenkler@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Julien Panis <jpanis@xxxxxxxxxxxx>, Chintan Vankar <c-vankar@xxxxxx>, Nicolas Pitre <npitre@xxxxxxxxxxxx>, Grygorii Strashko <grygorii.strashko@xxxxxx>, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx
In-reply-to: <b168d5c7-704b-4452-84f9-1c1762b1f4ce@stanley.mountain>
References: <b168d5c7-704b-4452-84f9-1c1762b1f4ce@stanley.mountain>
User-agent: Mozilla Thunderbird


On 16/10/2024 17:41, Dan Carpenter wrote:
> The *ndev pointer needs to be set or it leads to an uninitialized variable
> bug in the caller.
> 
> Fixes: 4a7b2ba94a59 ("net: ethernet: ti: am65-cpsw: Use tstats instead of open coded version")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Thanks Dan for this fix!

Reviewed-by: Roger Quadros <rogerq@xxxxxxxxxx>

References:
- [PATCH net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable
  - From: Dan Carpenter

Prev by Date: Re: [PATCH] staging: gpid: fmh: Drop residue from fmh_gpid_fifo_read_countable()
Next by Date: Re: [PATCH V2] staging: gpib: Remove a dead condition in if statement
Previous by thread: [PATCH net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable
Next by thread: Re: [PATCH net-next] net: ethernet: ti: am65-cpsw: Fix uninitialized variable
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]