I noticed that recently some debug sources were removed at [1], but some commented code were left inside some files, which I think was used at development stage. [1] https://lore.kernel.org/all/ab3d501e2ef0bb3980d8d271fb667ce20ed8dca5.1725826273.git.philipp.g.hortmann@xxxxxxxxx/ The change to pr_debug over hal/hal_com.c, function rtw_dump_raw_rssi_info(), doesn't impact the user since is reported as 'debug only' on the original caller: _linked_info_dump() I don't have the hw, just loaded the module inside qemu after those changes. Also, I'm suggesting in the series to remove the commented statements rather than changing them to pr_xxx() but I would like to ask an opinion about this. Tks and regards. Rodrigo Gobbi (2): staging: rtl8723bs: change remaining printk to proper api staging: rtl8723bs: remove unused debug statements drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- drivers/staging/rtl8723bs/hal/hal_com.c | 8 ++++---- drivers/staging/rtl8723bs/hal/odm.c | 4 ---- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 12 ++++++------ .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 12 +----------- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 17 ++--------------- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +- 7 files changed, 17 insertions(+), 44 deletions(-) -- 2.34.1
