On Sun, Oct 13, 2024 at 05:40:53PM +0200, Hans de Goede wrote:
> If atomisp fails to start the stream the buffers must be returned to
> the VB2_BUF_STATE_QUEUED state before returning an error from
> atomisp_start_streaming().
>
> This fixes the following WARN_ON():
> [ 250.313554] WARNING: CPU: 3 PID: 2178 at drivers/media/common/videobuf2/videobuf2-core.c:1801 vb2_start_streaming+0xcb/0x150 [videobuf2_common]
...
> if (ret) {
> dev_err(isp->dev, "Error starting mc pipeline: %d\n", ret);
> + atomisp_flush_video_pipe(pipe, VB2_BUF_STATE_QUEUED, true);
> goto out_unlock;
> }
Seems like error message does not depend on the video pipe. Hence I would
first flush the pipe and then print a message.
--
With Best Regards,
Andy Shevchenko
