Re: [PATCH 0/2] staging: vchiq_arm: Fix drv_mgmt leak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

[Treat this series as RFC]

On 13/10/24 2:15 pm, Umang Jain wrote:
1/2 is a drive by fix.
2/2 uses devres resouce management helper devm_kzalloc() to auto-free
struct vchiq_drv_mgmt on error and .remove() paths.

It might be good to aware the devres issue and following talk might
give reviewers a helpful context:

- https://lpc.events/event/16/contributions/1227/
- https://archive.fosdem.org/2023/schedule/event/devm_kzalloc/

I am not totally sure if these problems, causes a blockers for these
patches. There are a couple of memory management issues I've spotted
which can be fixed? by devres (similar to this series) but probably I
will wait for initial feedback on this series.

Was supposed to mark this as RFC for discussion and yes, I have realised I've not written a commit message for 2/2.

Umang Jain (2):
   staging: vchiq_arm: Drop blank lines
   staging: vchiq_arm: Use devm_kzalloc for mgmt

  .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c  | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux