Re: [PATCH 4/5] staging: vchiq_core: Macros indentation fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Umang Jain <umang.jain@xxxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>
Subject: Re: [PATCH 4/5] staging: vchiq_core: Macros indentation fix
From: Stefan Wahren <wahrenst@xxxxxxx>
Date: Thu, 10 Oct 2024 18:50:24 +0200
Cc: linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
In-reply-to: <20241010102250.236545-5-umang.jain@ideasonboard.com>
References: <20241010102250.236545-1-umang.jain@ideasonboard.com> <20241010102250.236545-5-umang.jain@ideasonboard.com>
Ui-outboundreport: notjunk:1;M01:P0:BeOGGQXhwrE=;sDrbDNtCXZGDQ0lzRcidJc+cWS/ GCpso9W+qRljlpcHT2tKRnItzjfMVMHTI/CcXsIAo50kON7ngfT5t6f6YqP58uv2W9yIrT1sR KyPmXFIsnBzaV+Qpb5JgMoEnRw8wDSDLFaFvNIzEZsSDTjF3fEcSgvclEWfvFiFCxsMylc/i9 oawDj54C1TLIQ1Dd+Tfg3ggWxe/CkjdbUImpkovHjDj+1+f0ifzv0WZVyLdSR2QeVN1SWlZF8 SOaAfB0mL4DnIkE8oCp7KCguwVFqP5d0h8O7/rc2JUNq8PnDjegiT7jemHGMRkC8ydsVE8Xqy eyZl1CUn12ZeQc0JRMWBcCQ83c956FvKckZGO5uMPTq9YWku0y/ycAWNQP5887QiXN9JzAv+J 08NHJBid3+th0mPNa16hcAWUfoPGrorasnpqBg4Xj8ybTU+dtsSqhDKm8KlEXhOpyK4XIHuhO yj7H156707T49vq9LdtfNOCYX3MlApAgLgUKgL3cu0HLCDDS/Cv/PiljjyTkhoegGpADdBsiC QmtBPMWITrft6vg6AmVVbhv8chJL7oGAjCI9IMzVXL/wtjH6+aYEhrgE+uuJOXPQxpTsm0S3H NpLBxVjw75usUCgRJjFAfCxs8S7H8QBbVD0XnxDUpg8troNPnH+ZGw+cYW5wroVdP36wXpfbg ulC1pbKue97mgSA+jypIrMZcwzYrQhSf/aTSHhgKPe5Pp7rFhq2lRnHG8vwZ5M73+uQPcaPDl f7I+LtbonuznJzyyeOjLgQXRPuLhsuEIKEfg2VToMZ1JXcBMxZiWopCazzkldvmKHf+a3CYYN 5nWRqc0gnUwotOsd13fYE4sA==
User-agent: Mozilla Thunderbird

Hi Umang,

Am 10.10.24 um 12:22 schrieb Umang Jain:

Make sure that MAKE_* macros fit within 80 columns instead of spanning
in a single line.

honestly i'm not a fan of this change, because it just silence
checkpatch but doesn't improve readability.

Regards

Follow-Ups:
- Re: [PATCH 4/5] staging: vchiq_core: Macros indentation fix
  - From: Greg Kroah-Hartman

References:
- [PATCH 0/5] staging: vchiq_core: Improve indentation
  - From: Umang Jain
- [PATCH 4/5] staging: vchiq_core: Macros indentation fix
  - From: Umang Jain

Prev by Date: [PATCH] staging: vt6655: Remove unused driver
Next by Date: Re: [PATCH 5/5] staging: vchiq_core: Locally cache cache_line_size information
Previous by thread: [PATCH 4/5] staging: vchiq_core: Macros indentation fix
Next by thread: Re: [PATCH 4/5] staging: vchiq_core: Macros indentation fix
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]