On Fri, Sep 27, 2024 at 09:42:13AM +0000, Ricardo Ribalda wrote: > The str_up_down() helper simplifies the code and fixes the following cocci > warning: > > drivers/media/platform/ti/cal/cal-camerarx.c:194:3-9: opportunity for str_up_down(enable) ... > if (i == 10) > phy_err(phy, "Failed to power %s complexio\n", > - enable ? "up" : "down"); > + str_up_down(enable); Now can fit one line phy_err(phy, "Failed to power %s complexio\n", str_up_down(enable)); But have you compiled it? > } -- With Best Regards, Andy Shevchenko
