On 9/23/24 2:09 PM, Xingquan Liu wrote:
Hi,
I'm a bit confused. Should I rename struct vnt_tx_desc
*apCurrTD[TYPE_MAXTD];
to curr_td?
It looks like 'ap' means array pointer.
Hi Xingquan,
yes I think so as well.
This line shows this:
priv->apCurrTD[0] = &priv->ap_td0_rings[0];
For struct vnt_rx_desc *aRD0Ring;, where 'a' doesn't means array, should
I rename it to rd0_ring?
When the "a" does not belong to hungarian notation it can remain.
The following is just my personal opinion:
You can keep working on this driver and your patches will remain in the
git. But I think I will propose to delete this driver. Reason is that it
supports maximum 54MBit/s and the connection is always weak. Its form
factor is mini PCI that is really old. I use an adapter from mini PCI to
PCI to get it into my Desktop PC. It furthermore is not buyable anymore.
I like to focus on the hardware that is really well useable and on the
market available:
For example:
rtl8712 (r8712u)
Backard Bell: AW-NU120
Thanks for your support.
Bye Philipp
