Re: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fabricio,

On 9/21/24 12:21, Fabricio Gasperin wrote:
Rename function sm750_hw_cursor_setData2 to sm_750_hw_cursor_setdata2

Change made in order to silence the camelCase warning from checkpatch.pl

Signed-off-by: Fabricio Gasperin <fgasperin@xxxxxxxxxx>
---
  drivers/staging/sm750fb/sm750_cursor.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
index eea4d1bd36ce..e95f39b51a2f 100644
--- a/drivers/staging/sm750fb/sm750_cursor.c
+++ b/drivers/staging/sm750fb/sm750_cursor.c
@@ -131,7 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
  	}
  }
-void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop,
+void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
  			      const u8 *pcol, const u8 *pmsk)
I think you missed one other occurrence of this function in the header (drivers/staging/sm750fb/sm750_cursor.h), which causes it to fail to build. Please fix the function name there as well. I think those are the only two occurrences of it, though.

  {
  	int i, j, count, pitch, offset;

Thanks,
Vinicius




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux