On Tue, Sep 17, 2024 at 10:00:01PM +0200, philipp hortmann wrote: > On Mon, Sep 16, 2024 at 10:31:35PM -0700, Tree Davies wrote: > > Rename variable nDataRate to data_rate > > to fix checkpatch warning Avoid CamelCase. > > > > Signed-off-by: Tree Davies <tdavies@xxxxxxxxxxxxxxx> > > --- > > drivers/staging/rtl8192e/rtllib.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h > > index d6615f787d53..21d8ea153368 100644 > > --- a/drivers/staging/rtl8192e/rtllib.h > > +++ b/drivers/staging/rtl8192e/rtllib.h > > @@ -1743,7 +1743,7 @@ extern u16 MCS_DATA_RATE[2][2][77]; > > u8 ht_c_check(struct rtllib_device *ieee, u8 *frame); > > void ht_reset_iot_setting(struct rt_hi_throughput *ht_info); > > bool is_ht_half_nmode_aps(struct rtllib_device *ieee); > > -u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); > > +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 data_rate); > > int rtllib_rx_add_ba_req(struct rtllib_device *ieee, struct sk_buff *skb); > > int rtllib_rx_add_ba_rsp(struct rtllib_device *ieee, struct sk_buff *skb); > > int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); > > -- > > 2.30.2 > > > Hi Tree, > > forget the former email. > > so in this commit: > commit ad96610acc0eb81f0342fa688e6d42fd530c328b > Author: Gary Rookard <garyrookard@xxxxxxxxxxxx> > Date: Tue Nov 28 13:17:27 2023 -0500 > the variable was changed. But he missed to change the declaration of the function tx_count_to_data_rate(). > > So you change the variable accordingly in the declaration of the functiont tx_count_to_data_rate() > > I assume that Greg would want you to use a fixes tag. > No, no need to a Fixes tag for this sort of thing. regards, dan carpenter
