On Sat, Sep 14, 2024 at 10:14:56PM +0530, Abhishek Tamboli wrote: > Hi Greg, > > On Sat, Sep 14, 2024 at 10:20:02AM +0200, Greg KH wrote: > > On Sat, Sep 14, 2024 at 12:47:34AM +0530, Abhishek Tamboli wrote: > > > Use the new api DECLARE_TASKLET instead of DECLARE_TASKLET_OLD > > > introduced in commit 12cc923f1ccc ("tasklet: Introduce new > > > initialization API"). > > > > This says what you are doing, but not why you are doing this. > > > > Why is this needed? What bug does this fix? The code is the exact same > > afterward so why should this be accepted? > > > While this patch doesn't fix any functional bug, it ensures that the > code is kept up to date with the new Initialization API for tasklets. You need to resend the patch with this information included in the commit message. regards, dan carpenter