On 8/31/24 18:08, Riyan Dhiman wrote:
static variable struct pci_device_id rtl8192_pci_id_tbl is not modified
in file rtl_core.c.
Constifying this structure moves some data to a read-only section, so
increase overall security.
Before
======
text data bss dec hex filename
17838 893 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o
After
=====
text data bss dec hex filename
18006 725 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o
Signed-off-by: Riyan Dhiman <riyandhiman14@xxxxxxxxx>
---
Compile tested only
--
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index ad21263e725f..22a203d01b8a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -25,7 +25,7 @@
int hwwep = 1;
static char *ifname = "wlan%d";
-static struct pci_device_id rtl8192_pci_id_tbl[] = {
+static const struct pci_device_id rtl8192_pci_id_tbl[] = {
{PCI_DEVICE(0x10ec, 0x8192)},
{PCI_DEVICE(0x07aa, 0x0044)},
{PCI_DEVICE(0x07aa, 0x0047)},
Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>