Re: [PATCH v2] Staging: rtl8723bs: Rename function SelectChannel()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 28, 2024 at 10:25:56PM +0200, Philipp Hortmann wrote:
> On 8/28/24 14:21, vivek t s wrote:
> > Rename SelectChannel() to r8723bs_select_channel() to avoid CamelCase
> > warning from checkpatch.
> > 
> > Signed-off-by: vivek t s<vivek6429.ts@xxxxxxxxx>
> 
> Hi Vivek,
> 
> the description can be improved. Please always consider that checkpatch can
> be wrong. So checkpatch is not a justification.
> 
> I propose (feel free to improve):
> Rename function SelectChannel() to r8723bs_select_channel() to avoid
> CamelCase and to improve cleanliness of the global namespace.
> 
> Thanks for your support.
> 
> Bye Philipp

okay, understood.
i shall change the description and send again.

thanks,
vivek








[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux