On Wed, Aug 28, 2024 at 03:04:57PM +0530, vivek t s wrote: > Rename SelectChannel() to select_channel() to avoid > CamelCase warning from checkpatch. I wouldn't have commented on this except there are some other issues. Line wrap your commit message at 72-75 characters (similar to email). So "CamelCase warning" moves to the line before. Rename SelectChannel() to select_channel() to avoid CamelCase warning from checkpatch. > > compile tested. > Put this under the --- cut off. (This is the real reason why I'm responding to your patch) > Signed-off-by: vivek t s <vivek6429.ts@xxxxxxxxx> Your signed-off-by is like signing a legal document. If you were buying a house, then would you write your name like this? If so then that's fine. > --- ^^^ Cut off line here. regards, dan carpenter > drivers/staging/rtl8723bs/core/rtw_ap.c | 4 ++-- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-)
