On Tue, Aug 27, 2024 at 04:56:19PM -0300, Nilo Alexandre wrote:
> Align parenthesis to improve readability.
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Nilo Alexandre <n1lux.comp@xxxxxxxxx>
> ---
> v3: Fix typo in commit message.
> v2: Using tabs instead of spaces.
> ---
> drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b767dc00100aa..2d17d8e8898e7 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
> if (priv->epromtype == EEPROM_93C46) {
> if (!priv->autoload_fail_flag) {
> usValue = rtl92e_eeprom_read(dev,
> - EEPROM_TxPwDiff_CrystalCap >> 1);
> + EEPROM_TxPwDiff_CrystalCap >> 1);
But it was aligned, your patch makes it misaligned, right?
Also, I couldn't apply this patch. Are you sure this patch was made on top
of Greg's staging tree?
I suspect that there is a linebreak here because of Linux's historical 80
columns limit. Now that the limit is raised to 100, perhaps it's better to
just remove the linebreak:
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b25e83743956..a80efe6c7c20 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
if (priv->epromtype == EEPROM_93C46) {
if (!priv->autoload_fail_flag) {
- usValue = rtl92e_eeprom_read(dev,
- EEPROM_TxPwDiff_CrystalCap >> 1);
+ usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
priv->eeprom_crystal_cap = (usValue & 0xf000)
>> 12;
