Added bound check for geoid in probe function because geoid will
always be positive and less than VME_MAX_SLOTS
Signed-off-by: Riyan Dhiman <riyandhiman14@xxxxxxxxx>
---
drivers/staging/vme_user/vme_fake.c | 7 +++++++
drivers/staging/vme_user/vme_tsi148.c | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index 7f84d1c86f29..d93a5d428ab9 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -1059,6 +1059,13 @@ static int __init fake_init(void)
struct vme_slave_resource *slave_image;
struct vme_lm_resource *lm;
+ /* If geoid provided, validate it is positive and less than VME_MAX_SLOTS */
+ if ((geoid) && (geoid < 0 || geoid >= VME_MAX_SLOTS)) {
+ pr_err("VME geographical address must be between 0 and %d (exclusive), but got %d\n",
+ VME_MAX_SLOTS, geoid);
+ return -EINVAL;
+ }
+
/* We need a fake parent device */
vme_root = root_device_register("vme");
if (IS_ERR(vme_root))
diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
index d81be8e4ceba..97323b5563e8 100644
--- a/drivers/staging/vme_user/vme_tsi148.c
+++ b/drivers/staging/vme_user/vme_tsi148.c
@@ -2252,6 +2252,13 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
struct vme_dma_resource *dma_ctrlr;
struct vme_lm_resource *lm;
+ /* If geoid provided, validate it is positive and less than VME_MAX_SLOTS */
+ if ((geoid) && (geoid < 0 || geoid >= VME_MAX_SLOTS)) {
+ pr_err("VME geographical address must be between 0 and %d (exclusive), but got %d\n",
+ VME_MAX_SLOTS, geoid);
+ return -EINVAL;
+ }
+
/* If we want to support more than one of each bridge, we need to
* dynamically generate this so we get one per device
*/
--
2.46.0
