On Fri, Aug 23, 2024, at 15:14, Umang Jain wrote: > > +int > +bulk_xfer_callback_interruptible(struct vchiq_instance *instance, > unsigned int handle, > + void *offset, void __user *uoffset, int size, > + enum vchiq_bulk_mode mode, void *userdata, > + enum vchiq_bulk_dir dir) It seems you can also tighten the argument types here a bit more: - uoffset is always NULL and can be left out - userdata is either NULL or a struct mmal_msg_context, so you can use that type directly. Arnd