On Wed, Aug 21, 2024 at 11:18:17PM +0530, Abhishek Tamboli wrote: > > Given this, would it be better to use strcat? > This would eliminate the need for the pname pointer and align with > the current code's method of concatenating the rtllib_modes. We can't ack the patch until we see it. Try it out and see if it looks good to you. regards, dan carpenter