Hi Abhishek, kernel test robot noticed the following build errors: [auto build test ERROR on staging/staging-testing] url: https://github.com/intel-lab-lkp/linux/commits/Abhishek-Tamboli/staging-rtl8192e-Replace-strcpy-with-strscpy-in-rtl819x_translate_scan/20240821-024358 base: staging/staging-testing patch link: https://lore.kernel.org/r/20240820184216.45390-1-abhishektamboli9%40gmail.com patch subject: [PATCH] staging: rtl8192e: Replace strcpy with strscpy in rtl819x_translate_scan config: um-allmodconfig (https://download.01.org/0day-ci/archive/20240821/202408211709.E9iGxQa8-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 26670e7fa4f032a019d23d56c6a02926e854e8af) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240821/202408211709.E9iGxQa8-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408211709.E9iGxQa8-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:8: In file included from include/linux/cacheflush.h:5: In file included from arch/um/include/asm/cacheflush.h:4: In file included from arch/um/include/asm/tlbflush.h:9: In file included from include/linux/mm.h:2228: include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from drivers/staging/rtl8192e/rtllib_wx.c:18: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/staging/rtl8192e/rtllib_wx.c:18: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/staging/rtl8192e/rtllib_wx.c:18: In file included from include/linux/etherdevice.h:20: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from arch/um/include/asm/hardirq.h:5: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/um/include/asm/io.h:24: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:693:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 693 | readsb(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:701:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 701 | readsw(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:709:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 709 | readsl(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:718:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 718 | writesb(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:727:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 727 | writesw(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ include/asm-generic/io.h:736:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 736 | writesl(PCI_IOBASE + addr, buffer, count); | ~~~~~~~~~~ ^ In file included from drivers/staging/rtl8192e/rtllib_wx.c:15: In file included from include/linux/wireless.h:13: In file included from include/uapi/linux/wireless.h:74: In file included from include/linux/socket.h:8: In file included from include/linux/uio.h:10: In file included from include/linux/mm_types.h:8: In file included from include/linux/kref.h:16: In file included from include/linux/spinlock.h:63: In file included from include/linux/lockdep.h:14: In file included from include/linux/smp.h:13: In file included from include/linux/cpumask.h:12: In file included from include/linux/bitmap.h:13: In file included from include/linux/string.h:374: >> include/linux/fortify-string.h:293:3: error: call to '__write_overflow' declared with 'error' attribute: detected write beyond size of object (1st parameter) 293 | __write_overflow(); | ^ 13 warnings and 1 error generated. vim +293 include/linux/fortify-string.h a28a6e860c6cf23 Francis Laniel 2021-02-25 274 03699f271de1f4d Kees Cook 2022-09-02 275 /* Defined after fortified strnlen() to reuse it. */ e6584c3964f2ff7 Kees Cook 2023-09-20 276 extern ssize_t __real_strscpy(char *, const char *, size_t) __RENAME(sized_strscpy); e6584c3964f2ff7 Kees Cook 2023-09-20 277 __FORTIFY_INLINE ssize_t sized_strscpy(char * const POS p, const char * const POS q, size_t size) a28a6e860c6cf23 Francis Laniel 2021-02-25 278 { a28a6e860c6cf23 Francis Laniel 2021-02-25 279 /* Use string size rather than possible enclosing struct size. */ 21a2c74b0a2a784 Kees Cook 2023-04-07 280 const size_t p_size = __member_size(p); 21a2c74b0a2a784 Kees Cook 2023-04-07 281 const size_t q_size = __member_size(q); 21a2c74b0a2a784 Kees Cook 2023-04-07 282 size_t len; a28a6e860c6cf23 Francis Laniel 2021-02-25 283 a28a6e860c6cf23 Francis Laniel 2021-02-25 284 /* If we cannot get size of p and q default to call strscpy. */ 311fb40aa0569ab Kees Cook 2022-09-02 285 if (p_size == SIZE_MAX && q_size == SIZE_MAX) a28a6e860c6cf23 Francis Laniel 2021-02-25 286 return __real_strscpy(p, q, size); a28a6e860c6cf23 Francis Laniel 2021-02-25 287 a28a6e860c6cf23 Francis Laniel 2021-02-25 288 /* a28a6e860c6cf23 Francis Laniel 2021-02-25 289 * If size can be known at compile time and is greater than a28a6e860c6cf23 Francis Laniel 2021-02-25 290 * p_size, generate a compile time write overflow error. a28a6e860c6cf23 Francis Laniel 2021-02-25 291 */ fa35198f39571bb Kees Cook 2022-09-19 292 if (__compiletime_lessthan(p_size, size)) a28a6e860c6cf23 Francis Laniel 2021-02-25 @293 __write_overflow(); a28a6e860c6cf23 Francis Laniel 2021-02-25 294 62e1cbfc5d79538 Kees Cook 2022-10-02 295 /* Short-circuit for compile-time known-safe lengths. */ 62e1cbfc5d79538 Kees Cook 2022-10-02 296 if (__compiletime_lessthan(p_size, SIZE_MAX)) { 62e1cbfc5d79538 Kees Cook 2022-10-02 297 len = __compiletime_strlen(q); 62e1cbfc5d79538 Kees Cook 2022-10-02 298 62e1cbfc5d79538 Kees Cook 2022-10-02 299 if (len < SIZE_MAX && __compiletime_lessthan(len, size)) { 62e1cbfc5d79538 Kees Cook 2022-10-02 300 __underlying_memcpy(p, q, len + 1); 62e1cbfc5d79538 Kees Cook 2022-10-02 301 return len; 62e1cbfc5d79538 Kees Cook 2022-10-02 302 } 62e1cbfc5d79538 Kees Cook 2022-10-02 303 } 62e1cbfc5d79538 Kees Cook 2022-10-02 304 a28a6e860c6cf23 Francis Laniel 2021-02-25 305 /* a28a6e860c6cf23 Francis Laniel 2021-02-25 306 * This call protects from read overflow, because len will default to q a28a6e860c6cf23 Francis Laniel 2021-02-25 307 * length if it smaller than size. a28a6e860c6cf23 Francis Laniel 2021-02-25 308 */ a28a6e860c6cf23 Francis Laniel 2021-02-25 309 len = strnlen(q, size); a28a6e860c6cf23 Francis Laniel 2021-02-25 310 /* a28a6e860c6cf23 Francis Laniel 2021-02-25 311 * If len equals size, we will copy only size bytes which leads to a28a6e860c6cf23 Francis Laniel 2021-02-25 312 * -E2BIG being returned. a28a6e860c6cf23 Francis Laniel 2021-02-25 313 * Otherwise we will copy len + 1 because of the final '\O'. a28a6e860c6cf23 Francis Laniel 2021-02-25 314 */ a28a6e860c6cf23 Francis Laniel 2021-02-25 315 len = len == size ? size : len + 1; a28a6e860c6cf23 Francis Laniel 2021-02-25 316 a28a6e860c6cf23 Francis Laniel 2021-02-25 317 /* a28a6e860c6cf23 Francis Laniel 2021-02-25 318 * Generate a runtime write overflow error if len is greater than a28a6e860c6cf23 Francis Laniel 2021-02-25 319 * p_size. a28a6e860c6cf23 Francis Laniel 2021-02-25 320 */ 3d965b33e40d973 Kees Cook 2023-04-07 321 if (p_size < len) 3d965b33e40d973 Kees Cook 2023-04-07 322 fortify_panic(FORTIFY_FUNC_strscpy, FORTIFY_WRITE, p_size, len, -E2BIG); a28a6e860c6cf23 Francis Laniel 2021-02-25 323 a28a6e860c6cf23 Francis Laniel 2021-02-25 324 /* a28a6e860c6cf23 Francis Laniel 2021-02-25 325 * We can now safely call vanilla strscpy because we are protected from: a28a6e860c6cf23 Francis Laniel 2021-02-25 326 * 1. Read overflow thanks to call to strnlen(). a28a6e860c6cf23 Francis Laniel 2021-02-25 327 * 2. Write overflow thanks to above ifs. a28a6e860c6cf23 Francis Laniel 2021-02-25 328 */ a28a6e860c6cf23 Francis Laniel 2021-02-25 329 return __real_strscpy(p, q, len); a28a6e860c6cf23 Francis Laniel 2021-02-25 330 } a28a6e860c6cf23 Francis Laniel 2021-02-25 331 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
