On Fri, Jul 05, 2024 at 11:44:34PM +0300, Aleksandr Mishin wrote:
> In ks_wlan_get_range() variable 'i' which value is always 12, is compared
> to 2. This check is unneeded and should be removed.
>
> Remove unneeded check to clean up the code.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")
> Signed-off-by: Aleksandr Mishin <amishin@xxxxxxxxxx>
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
> index 0fb97a79ad0b..d56dae73e7ed 100644
> --- a/drivers/staging/ks7010/ks_wlan_net.c
> +++ b/drivers/staging/ks7010/ks_wlan_net.c
> @@ -972,10 +972,7 @@ static int ks_wlan_get_range(struct net_device *dev,
> * in bit/s that we can expect using this interface.
> * May be use for QoS stuff... Jean II
> */
> - if (i > 2)
> - range->throughput = 5000 * 1000;
> - else
> - range->throughput = 1500 * 1000;
> + range->throughput = 5000 * 1000;
>
This is part of a custom IOCTL. According to the comment, we're
providing the 5 million as information to the user which I guess they
might use for QoS stuff... It's kind of pointless.
Anway, the patch doesn't make anything worse.
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
KTODO: delete custom ioctls in ks7010. (requires careful audit or testing)
regards,
dan carpenter
