On Wed, Jun 26, 2024 at 01:56:34PM +0100, Yusef Aslam wrote:
> From: Yusef Aslam <YUZi54780@xxxxxxxxxxx>
> Date: Wed, 26 Jun 2024 13:02:02 +0100
> Subject: [PATCH v3] Staging: rtl8192e: rtllib_rx: fix alignment
This all should not be in the body of the email, please use a tool like
'git send-email' to send patches.
>
> Fix alignment.
We need more description than that, right? What would you want to see
here?
>
> Signed-off-by: Yusef Aslam <YUZi54780@xxxxxxxxxxx>
> ---
> v3:
> - Used the correct email addresses.
> - Developed against the correct git repository.
> v2:
> - The email address of Greg Kroah-Hartman was wrong.
> - Developed against the wrong git repository.
> v1:
> - Developed against the wrong git repository.
>
> drivers/staging/rtl8192e/rtllib_rx.c | 110 +++++++++++++--------------
> 1 file changed, 55 insertions(+), 55 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 84ca5d769b7e..1f6c4a3de5c2 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -410,7 +410,7 @@ static bool add_reorder_entry(struct rx_ts_record *ts,
> while (list->next != &ts->rx_pending_pkt_list) {
> if (SN_LESS(pReorderEntry->SeqNum, ((struct rx_reorder_entry *)
> list_entry(list->next, struct rx_reorder_entry,
> - list))->SeqNum))
> + list))->SeqNum))
> list = list->next;
> else if (SN_EQUAL(pReorderEntry->SeqNum,
> ((struct rx_reorder_entry *)list_entry(list->next,
> @@ -736,7 +736,7 @@ static u8 parse_subframe(struct rtllib_device *ieee, struct sk_buff *skb,
> /* just for debug purpose */
> SeqNum = WLAN_GET_SEQ_SEQ(le16_to_cpu(hdr->seq_ctrl));
> if ((RTLLIB_QOS_HAS_SEQ(fc)) &&
> - (((union frameqos *)(skb->data + RTLLIB_3ADDR_LEN))->field.reserved))
> + (((union frameqos *)(skb->data + RTLLIB_3ADDR_LEN))->field.reserved))
> is_aggregate_frame = true;
>
> if (RTLLIB_QOS_HAS_SEQ(fc))
> @@ -876,13 +876,13 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
> frag = WLAN_GET_SEQ_FRAG(sc);
>
> if (!ieee->ht_info->cur_rx_reorder_enable ||
> - !ieee->current_network.qos_data.active ||
> - !is_data_frame(skb->data) ||
> - is_legacy_data_frame(skb->data)) {
> - if (!ieee80211_is_beacon(hdr->frame_control)) {
> - if (is_duplicate_packet(ieee, hdr))
> - return -1;
> - }
> + !ieee->current_network.qos_data.active ||
> + !is_data_frame(skb->data) ||
> + is_legacy_data_frame(skb->data)) {
> + if (!ieee80211_is_beacon(hdr->frame_control)) {
> + if (is_duplicate_packet(ieee, hdr))
> + return -1;
> + }
That's obviously not correct. Did you run your patch through
checkpatch.pl after creating it?
thanks,
greg k-h
