回复: [PATCH v4 08/13] staging: media: starfive: Add for StarFive ISP 3A SC

[Changhuang Liang <changhuang.liang@xxxxxxxxxxxxxxxx>]

Hi, Hans,

Thanks for your comment

[...]
> > +static int video_scd_queue_setup(struct vb2_queue *q,
> > +				 unsigned int *num_buffers,
> > +				 unsigned int *num_planes,
> > +				 unsigned int sizes[],
> > +				 struct device *alloc_devs[])
> > +{
> 
> This still needs:
> 
>         if (*nplanes)
>                 return sizes[0] < sizeof(struct jh7110_isp_sc_buffer) ?
> -EINVAL : 0;
> 

Will add this.

> for proper VIDIOC_CREATEBUFS support.
> 
> Otherwise this will probably fail with 'v4l2-compliance -s'.
> 
[...]

Regards,
Changhuang