Quoting Stefan Wahren (2024-06-20 17:59:39)
> Hi Kieran,
>
> Am 14.06.24 um 13:31 schrieb Kieran Bingham:
> > Quoting Stefan Wahren (2024-06-14 12:00:38)
> >> Hi Kieran,
> >>
> >> Am 14.06.24 um 12:43 schrieb Kieran Bingham:
> >>> The vchiq_state used to be obtained through an accessor
> >>> which would validate that the VCHIQ had been initialised
> >>> correctly with the remote.
> >>>
> >>> In commit 42a2f6664e18 ("staging: vc04_services: Move global g_state to
> >>> vchiq_state") the global state was moved to the vchiq_mgnt structures
> >>> stored as a vchiq instance specific context. This conversion removed the
> >>> helpers and instead replaced users of this helper with the assumption
> >>> that the state is always available and the remote connected.
> >>>
> >>> Fix this broken assumption by re-introducing the logic that was lost
> >>> during the conversion.
> >>>
> >>> Fixes: 42a2f6664e18 ("staging: vc04_services: Move global g_state to vchiq_state")
> >>> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> >>> ---
> >>> v2:
> >>> - No change, just resend
> >> what happen to my comments for the first version?
> > Err ... i missed them ... let me go back and look!
> sorry for pestering, but could you please send v3 of the fix? I want to
> rebase my cleanup series on top of that, because bisecting vchiq is
> currently no fun.
I can imagine! Sorry for the delay, should be out on the lists and in
your inbox now.
--
Kieran
>
> Thanks
> Stefan
> >
> > --
> > Kieran
>
