Hi Stefan,
Thank you for the patch.
On Tue, Jun 04, 2024 at 07:29:03PM +0200, Stefan Wahren wrote:
> The number format of VCHIQ debugfs isn't always clear. So let's
> add a prefix for all hex values, in order to make things clear.
>
> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 51cfc366519b..4f65e4021c4d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -3370,7 +3370,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state,
> };
> int i;
>
> - seq_printf(f, " %s: slots %d-%d tx_pos=%x recycle=%x\n",
> + seq_printf(f, " %s: slots %d-%d tx_pos=0x%x recycle=0x%x\n",
> label, shared->slot_first, shared->slot_last,
> shared->tx_pos, shared->slot_queue_recycle);
>
> @@ -3386,7 +3386,7 @@ vchiq_dump_shared_state(struct seq_file *f, struct vchiq_state *state,
> }
>
> for (i = 1; i < shared->debug[DEBUG_ENTRIES]; i++) {
> - seq_printf(f, " DEBUG: %s = %d(%x)\n",
> + seq_printf(f, " DEBUG: %s = %d(0x%x)\n",
> debug_names[i], shared->debug[i], shared->debug[i]);
> }
> }
> @@ -3414,7 +3414,7 @@ vchiq_dump_service_state(struct seq_file *f, struct vchiq_service *service)
>
> if (service->public_fourcc != VCHIQ_FOURCC_INVALID)
> scnprintf(remoteport + len2, sizeof(remoteport) - len2,
> - " (client %x)", service->client_id);
> + " (client 0x%x)", service->client_id);
> } else {
> strscpy(remoteport, "n/a", sizeof(remoteport));
> }
> @@ -3475,7 +3475,7 @@ void vchiq_dump_state(struct seq_file *f, struct vchiq_state *state)
> seq_printf(f, "State %d: %s\n", state->id,
> conn_state_names[state->conn_state]);
>
> - seq_printf(f, " tx_pos=%x(@%pK), rx_pos=%x(@%pK)\n",
> + seq_printf(f, " tx_pos=0x%x(@%pK), rx_pos=0x%x(@%pK)\n",
> state->local->tx_pos,
> state->tx_data + (state->local_tx_pos & VCHIQ_SLOT_MASK),
> state->rx_pos,
--
Regards,
Laurent Pinchart
