On Sun, Apr 14, 2024 at 03:42:58PM +0530, sumadhura kalyan wrote: > Issue found by checkpatch > > Signed-off-by: sumadhura kalyan <opensourcecond@xxxxxxxxx> > --- > drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > index a0cdd28101f2..d811bfd3bb84 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h > @@ -27,7 +27,7 @@ > /** Common parameter ID group, used with many types of component. */ > #define MMAL_PARAMETER_GROUP_COMMON (0 << 16) > /** Camera-specific parameter ID group. */ > -#define MMAL_PARAMETER_GROUP_CAMERA (1 << 16) > +#define MMAL_PARAMETER_GROUP_CAMERA BIT(16) > /** Video-specific parameter ID group. */ > #define MMAL_PARAMETER_GROUP_VIDEO (2 << 16) > /** Audio-specific parameter ID group. */ When looking at the code now, does this change make sense? Remember, checkpatch is a guide, not a hard rule. greg k-h
